brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: make ConfigBag thread-safe
Date Thu, 09 Apr 2015 11:29:44 GMT
GitHub user ahgittin opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/589

    make ConfigBag thread-safe

    `ConfigBag` has not been thread-safe, but we have been accessing it from multiple threads.
 This can cause `ConcurrentModificationException` to be thrown in many places.
    
    Such a higher-level shared class should be thread-safe, and this makes it so by synchronizing
on the `ConfigBag` class appropriately.  As we do not have iterators here it was pretty straightforward.
 (You get a copy of the map to iterate -- that has always been the case.)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/incubator-brooklyn config-bag-thread-safe

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/589.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #589
    
----
commit 5e34f950f1d6a7875224112b60ae2de810b18feb
Author: Alex Heneveld <alex.heneveld@cloudsoftcorp.com>
Date:   2015-04-09T11:26:18Z

    make ConfigBag thread-safe

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message