brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Coerce aggregated sensor values
Date Thu, 23 Apr 2015 14:04:39 GMT
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/609#issuecomment-95596861
  
    Looks really good.
    
    Am a tiny bit concerned about us ignoring entity's serviceUp when serviceState is null
(as that is a change in behaviour for a situation where the expected behaviour is unclear.
However, on balance I'm fine with this.
    
    Merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message