brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Store additional config in the ri...
Date Mon, 20 Apr 2015 10:28:52 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/606#discussion_r28678069
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/riak/RiakNodeSshDriver.java
---
    @@ -251,6 +251,15 @@ public void customize() {
                 String saveAsRiakConf = Urls.mergePaths(getRunDir(), "riak.conf");
                 DynamicTasks.queueIfPossible(SshEffectorTasks.put(saveAsRiakConf).contents(riakConfTemplate));
                 commands.add(sudo("mv " + saveAsRiakConf + " " + getRiakEtcDir()));
    +
    +            if(!osDetails.isMac()) {
    +                if(!com.google.common.base.Strings.isNullOrEmpty(entity.getConfig(RiakNode.RIAK_CONFIG_FILE)))
{
    +                    String configTemplate = processTemplateContents(entity.getConfig(RiakNode.RIAK_CONFIG_FILE));
    +                    String saveAsConfig = Urls.mergePaths(getRunDir(), "riak_extra.conf");
    +                    DynamicTasks.queueIfPossible(SshEffectorTasks.put(saveAsConfig).contents(configTemplate));
    +                    commands.add(sudo("cat " + saveAsConfig + " >> " + getRiakEtcDir()
+ "/riak.conf"));
    --- End diff --
    
    `customize` step is called on each start, which will lead to multiple copies of the config
appended.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message