brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Add multiple items to catalog wit...
Date Sat, 18 Apr 2015 17:29:25 GMT
Github user neykov commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/585#issuecomment-94185256
  
    Finished review, useful functionality moving us closer to getting rid of XML.
    Only major concern is CI resolution will fail if id:version reference used. As soon as
addressed the PR can be merged. Worth adding a test as well.
    The changes are a bit on the dirty side, missing some corner cases with the validation
(when child catalog item references are involved), but on the other hand the changes are self
contained which is good - we can fix this additionally if it proves to be a problem in real
world use.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message