brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: allow dsl commands to get an enti...
Date Sat, 18 Apr 2015 16:27:57 GMT
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/600#issuecomment-94178604
  
    neat idea -- but some concerns
    
    share concern about overloading `descendant(type)` vs `id`, esp as type is likely to have
many more matches.
    
    i'm also concerned that `type` is too specific here, it two ways.  we don't check against
java supertypes (it's just a string match), and if we are using catalog items which extend
other catalog items and java types we don't match those.
    
    i wonder if there is a better way to achieve what this is trying to achieve.  what is
the use case?
    
    (also we should update docs, yaml-reference.md at least, when introducing such features)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message