brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Parse service types in YAML using...
Date Sun, 12 Apr 2015 21:36:12 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/587#discussion_r28207771
  
    --- Diff: usage/camp/src/main/java/io/brooklyn/camp/brooklyn/spi/creation/service/ServiceTypeResolver.java
---
    @@ -0,0 +1,73 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package io.brooklyn.camp.brooklyn.spi.creation.service;
    +
    +import java.util.ServiceLoader;
    +
    +import io.brooklyn.camp.brooklyn.spi.creation.BrooklynComponentTemplateResolver;
    +import brooklyn.catalog.CatalogItem;
    +import brooklyn.entity.Entity;
    +import brooklyn.entity.proxying.EntitySpec;
    +
    +/**
    + * Resolves and decorates {@link EntitySpec entity specifications} based on the {@code
serviceType} in a template.
    + * <p>
    + * The {@link #getTypePrefix()} method returns a string that should match the beginning
of the
    + * service type. The resolver implementation will use the rest of the service type information
    + * to create and decorate an approprate {@link EntitySpec entity}.
    + * <p>
    + * The resolvers are loaded using the {@link ServiceLoader} mechanism, allowing external
libraries
    + * to add extra service type implementations that will be picked up at runtime.
    + *
    + * @see BrooklynServiceTypeResolver
    + * @see ChefServiceTypeResolver
    + */
    +public interface ServiceTypeResolver {
    +
    +    String DEFAULT_TYPE_PREFIX = "brooklyn";
    +
    +    /**
    +     * The service type prefix the resolver is responsible for.
    +     */
    +    String getTypePrefix();
    --- End diff --
    
    I wonder about also having an `accepts(String serviceType)` or an `accepts(BrooklynComponentTemplateResolver
resolver, String serviceType)` - i.e. similar to `LocationResolver` - but no strong feelings.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message