brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: allow open ports to be specified ...
Date Sun, 12 Apr 2015 16:42:41 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/592#discussion_r28205082
  
    --- Diff: software/base/src/main/java/brooklyn/entity/basic/SoftwareProcessImpl.java ---
    @@ -429,8 +432,21 @@ protected final void callStartHooks() {}
                 if (PortRange.class.isAssignableFrom(k.getType())) {
                     PortRange p = (PortRange)getConfig(k);
                     if (p != null && !p.isEmpty()) ports.add(p.iterator().next());
    +            }   
    +        }
    +        
    +        Map<String, Object> provisioningProperties = getConfig(PROVISIONING_PROPERTIES);
    +        if(provisioningProperties.containsKey("required.ports")){
    --- End diff --
    
    The other keys in `PROVISIONING_PROPERTIES` correspond to `ConfigKey`s, such as those
in `CloudLocationConfig`. It would be good to include `required.ports` as a `ConfigKey` there,
rather than as a hard-coded string. If we do that, then it also needs to be respected by `JcloudsLocation`
etc.
    
    Also, there is a `CloudLocationConfig.INBOUND_PORTS` config key. If you set that in `PROVISIONING_PROPERTIES`
then it (unfortunately but understandably) overrides all other values from the `getRequiredOpenPorts`.
We could augment this with a `ADDITIONAL_INBOUND_PORTS` config key perhaps?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message