brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <>
Subject [GitHub] incubator-brooklyn pull request: Riak - Create Bucket type effecto...
Date Tue, 07 Apr 2015 13:29:37 GMT
Github user ahgittin commented on a diff in the pull request:
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/riak/ ---
    @@ -183,18 +183,31 @@
         String getOsMajorVersion();
         @Effector(description = "Join the Riak cluster on the given node")
    -    public void joinCluster(@EffectorParam(name = "nodeName") String nodeName);
    +    void joinCluster(@EffectorParam(name = "nodeName") String nodeName);
         @Effector(description = "Leave the Riak cluster")
    -    public void leaveCluster();
    +    void leaveCluster();
         @Effector(description = "Remove the given node from the Riak cluster")
    -    public void removeNode(@EffectorParam(name = "nodeName") String nodeName);
    +    void removeNode(@EffectorParam(name = "nodeName") String nodeName);
         @Effector(description = "Recover and join the Riak cluster on the given node")
    -    public void recoverFailedNode(@EffectorParam(name = "nodeName") String nodeName);
    +    void recoverFailedNode(@EffectorParam(name = "nodeName") String nodeName);
    -    @Effector(description = "Commit changes made to the Riak cluster")
    -    public void commitCluster();
    +    @Effector(description = "Create bucket type")
    +    void bucketTypeCreate(@EffectorParam(name = "bucketTypeName") String bucketTypeName,
    --- End diff --
    verb first is the usual pattern for methods isn't it?   so `createBucketType`

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message