brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Riak - Create Bucket type effecto...
Date Tue, 07 Apr 2015 13:17:28 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/581#discussion_r27876100
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/riak/RiakNodeSshDriver.java
---
    @@ -395,12 +390,12 @@ public void joinCluster(String nodeName) {
                 if (!hasJoinedCluster()) {
                     ScriptHelper joinClusterScript = newScript("joinCluster")
                             .body.append(sudo(format("%s cluster join %s", getRiakAdminCmd(),
nodeName)))
    +                        .body.append(sudo(format("%s cluster plan", getRiakAdminCmd())))
    +                        .body.append(sudo(format("%s cluster commit", getRiakAdminCmd())))
    --- End diff --
    
    agree, it feels like our default behaviour should be to commit.
    
    we could (in time) add an optional parameter "commitChange" which defaults to true, that
way if someone wanted to they could batch/preview changes.
    
    i'd say add a TODO with this (and reference the commit which includes the commitCluster
effector, in case we want to revive that we can copy-paste from here.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message