Return-Path: 
 <dev-return-6347-apmail-brooklyn-dev-archive=brooklyn.apache.org@brooklyn.incubator.apache.org>
X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 58C981751B
	for <apmail-brooklyn-dev-archive@minotaur.apache.org>;
 Thu, 19 Mar 2015 16:20:09 +0000 (UTC)
Received: (qmail 49351 invoked by uid 500); 19 Mar 2015 16:20:09 -0000
Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org
Received: (qmail 49319 invoked by uid 500); 19 Mar 2015 16:20:09 -0000
Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.incubator.apache.org>
List-Post: <mailto:dev@brooklyn.incubator.apache.org>
List-Id: <dev.brooklyn.incubator.apache.org>
Reply-To: dev@brooklyn.incubator.apache.org
Delivered-To: mailing list dev@brooklyn.incubator.apache.org
Received: (qmail 49308 invoked by uid 99); 19 Mar 2015 16:20:09 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Mar 2015 16:20:09 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Thu, 19 Mar 2015 16:20:07 +0000
Received: (qmail 47658 invoked by uid 99); 19 Mar 2015 16:19:47 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Mar 2015 16:19:47 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id B611DE192B; Thu, 19 Mar 2015 16:19:47 +0000 (UTC)
From: aledsage <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-559-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-559-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: group rescan should be
 triggered ...
Content-Type: text/plain
Message-Id: <20150319161947.B611DE192B@git1-us-west.apache.org>
Date: Thu, 19 Mar 2015 16:19:47 +0000 (UTC)
X-Virus-Checked: Checked by ClamAV on apache.org

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/559#discussion_r26770285
  
    --- Diff: core/src/main/java/brooklyn/entity/basic/DynamicGroupImpl.java ---
    @@ -163,13 +165,20 @@ public void onManagementBecomingMaster() {
             }
             setChangeListener = new MyEntitySetChangeListener();
             ((ManagementContextInternal) getManagementContext()).addEntitySetListener(setChangeListener);
    -        try {
    -            rescanEntities();
    -        } catch (Exception e) {
    -            log.warn("Error rescanning entities when rebinding; may be a group set against an unknown entity: "+e);
    -            log.debug("Trace for rescan entities error", e);
    -            Exceptions.propagateIfFatal(e);
    -        }
    +        Task<Object> rescan = Tasks.builder().name("rescan entities").body(
    +            new Runnable() {
    +                @Override
    +                public void run() {
    +                    try {
    +                        rescanEntities();
    +                    } catch (Exception e) {
    +                        log.warn("Error rescanning entities when rebinding; may be a group set against an unknown entity: "+e);
    --- End diff --
    
    This is not just called on rebind - it's called when the entity is very created+managed as well.
    Perhaps a better message would just be `"Error rescanning for members of "+DynamicGroupImpl.this+"; may be a ..."`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---