Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-554-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-554-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: fixes for BrooklynNode and
 java a...
Content-Type: text/plain
Message-Id: <20150318122042.7817EE1873@git1-us-west.apache.org>
Date: Wed, 18 Mar 2015 12:20:42 +0000 (UTC)

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/554#discussion_r26657763
  
    --- Diff: core/src/main/java/brooklyn/entity/rebind/dto/MementosGenerators.java ---
    @@ -68,10 +71,23 @@
     
         private MementosGenerators() {}
         
    +    /** @deprecated since 0.7.0 use {@link #newBasicMemento(BrooklynObject)} */
    --- End diff --
    
    This isn't the real memento as per new java doc.  The old name confused me
    and caused the manual export failures.
    On 18 Mar 2015 11:59, "Aled Sage" <notifications@github.com> wrote:
    
    > In core/src/main/java/brooklyn/entity/rebind/dto/MementosGenerators.java
    > <https://github.com/apache/incubator-brooklyn/pull/554#discussion_r26656722>
    > :
    >
    > > @@ -68,10 +71,23 @@
    > >
    > >      private MementosGenerators() {}
    > >
    > > +    /** @deprecated since 0.7.0 use {@link #newBasicMemento(BrooklynObject)} */
    >
    > Why rename from newMemento(BrooklynObject) to
    > newBasicMemento(BrooklynObject)? Do we have anything but "basic", or are
    > we expecting that in the near future? Personally I prefer newMemento, as
    > "basic" implies there is some other kind of memento out there.
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/incubator-brooklyn/pull/554/files#r26656722>.
    >


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---