Return-Path: X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 29D681752D for ; Wed, 18 Mar 2015 12:00:03 +0000 (UTC) Received: (qmail 64377 invoked by uid 500); 18 Mar 2015 12:00:03 -0000 Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org Received: (qmail 64336 invoked by uid 500); 18 Mar 2015 12:00:03 -0000 Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.incubator.apache.org Delivered-To: mailing list dev@brooklyn.incubator.apache.org Received: (qmail 64325 invoked by uid 99); 18 Mar 2015 12:00:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Mar 2015 12:00:02 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 18 Mar 2015 12:00:01 +0000 Received: (qmail 64178 invoked by uid 99); 18 Mar 2015 11:59:41 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Mar 2015 11:59:41 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8DB69E0989; Wed, 18 Mar 2015 11:59:41 +0000 (UTC) From: aledsage To: dev@brooklyn.incubator.apache.org Reply-To: dev@brooklyn.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-brooklyn pull request: fixes for BrooklynNode and java a... Content-Type: text/plain Message-Id: <20150318115941.8DB69E0989@git1-us-west.apache.org> Date: Wed, 18 Mar 2015 11:59:41 +0000 (UTC) X-Virus-Checked: Checked by ClamAV on apache.org Github user aledsage commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/554#discussion_r26656722 --- Diff: core/src/main/java/brooklyn/entity/rebind/dto/MementosGenerators.java --- @@ -68,10 +71,23 @@ private MementosGenerators() {} + /** @deprecated since 0.7.0 use {@link #newBasicMemento(BrooklynObject)} */ --- End diff -- Why rename from `newMemento(BrooklynObject)` to `newBasicMemento(BrooklynObject)`? Do we have anything but "basic", or are we expecting that in the near future? Personally I prefer `newMemento`, as "basic" implies there is some other kind of memento out there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---