Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: aledsage <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-542-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-542-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Mirroring entities should
 wait fo...
Content-Type: text/plain
Message-Id: <20150311123010.C0634E1850@git1-us-west.apache.org>
Date: Wed, 11 Mar 2015 12:30:10 +0000 (UTC)

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/542#discussion_r26207634
  
    --- Diff: core/src/main/java/brooklyn/management/ha/HighAvailabilityManagerImpl.java ---
    @@ -1077,4 +1077,13 @@ public String toString() {
             return result;
         }
         
    +    @Override
    +    public long getLastStateChange() {
    +        if (nodeStateHistory.size() > 0) {
    +            return (Long)nodeStateHistory.get(0).get("timestamp");
    +        } else {
    +            return 0;
    --- End diff --
    
    Personal preference for returning `-1` to signify not available (as 0 is an unlikely but valid timestamp)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---