Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: neykov <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-545-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-545-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Encapsulate all CAMP calls
 in a s...
Content-Type: text/plain
Message-Id: <20150309152238.C9F56E17F4@git1-us-west.apache.org>
Date: Mon,  9 Mar 2015 15:22:38 +0000 (UTC)

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/545#discussion_r26044508
  
    --- Diff: usage/camp/src/main/java/io/brooklyn/camp/brooklyn/YamlLauncherAbstract.java ---
    @@ -130,4 +126,13 @@ public void destroyAll() {
             }
         }
     
    +   private Application createFromUrl(Reader reader) {
    --- End diff --
    
    The argument is no longer a URL, rename method. Also the TODO below is not needed in this case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---