Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: aledsage <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-540-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-540-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Allows catalog items to be
 deprec...
Content-Type: text/plain
Message-Id: <20150304211859.67C9EE0F7F@git1-us-west.apache.org>
Date: Wed,  4 Mar 2015 21:18:59 +0000 (UTC)

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/540#discussion_r25814854
  
    --- Diff: core/src/main/java/brooklyn/catalog/internal/BasicBrooklynCatalog.java ---
    @@ -272,6 +273,11 @@ public void deleteCatalogItem(String symbolicName, String version) {
                 return (CatalogItem<T,SpecT>)result;
             return null;
         }
    +
    +    public void persist(CatalogItem<?, ?> catalogItem) {
    --- End diff --
    
    Should this also be on the interface `BrooklynCatalog`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---