Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: aledsage <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-538-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-538-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Adds addAssociationListener
 and r...
Content-Type: text/plain
Message-Id: <20150302205301.97829E0FC8@git1-us-west.apache.org>
Date: Mon,  2 Mar 2015 20:53:01 +0000 (UTC)

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/538#discussion_r25637263
  
    --- Diff: core/src/main/java/brooklyn/location/access/PortForwardManagerImpl.java ---
    @@ -78,7 +78,9 @@
         private static final Logger log = LoggerFactory.getLogger(PortForwardManagerImpl.class);
         
         protected final Map<String,PortMapping> mappings = new LinkedHashMap<String,PortMapping>();
    -    
    +
    +    private Map<AssociationListener, Predicate<? super AssociationMetadata>> associationListeners = new ConcurrentHashMap<AssociationListener, Predicate<? super AssociationMetadata>>();
    --- End diff --
    
    Declare the field `final`. It makes reasoning about the code simpler for folk reading or modifying it later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---