Return-Path: 
 <dev-return-6043-apmail-brooklyn-dev-archive=brooklyn.apache.org@brooklyn.incubator.apache.org>
X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 3FAA617897
	for <apmail-brooklyn-dev-archive@minotaur.apache.org>;
 Mon,  2 Mar 2015 16:26:26 +0000 (UTC)
Received: (qmail 25700 invoked by uid 500); 2 Mar 2015 16:26:26 -0000
Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org
Received: (qmail 25663 invoked by uid 500); 2 Mar 2015 16:26:26 -0000
Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.incubator.apache.org>
List-Post: <mailto:dev@brooklyn.incubator.apache.org>
List-Id: <dev.brooklyn.incubator.apache.org>
Reply-To: dev@brooklyn.incubator.apache.org
Delivered-To: mailing list dev@brooklyn.incubator.apache.org
Received: (qmail 25652 invoked by uid 99); 2 Mar 2015 16:26:25 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Mar 2015 16:26:25 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Mon, 02 Mar 2015 16:26:24 +0000
Received: (qmail 24011 invoked by uid 99); 2 Mar 2015 16:24:48 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Mar 2015 16:24:48 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id D40DFE03B9; Mon,  2 Mar 2015 16:24:48 +0000 (UTC)
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-531-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-531-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Basho Riak - Linux Install
Content-Type: text/plain
Message-Id: <20150302162448.D40DFE03B9@git1-us-west.apache.org>
Date: Mon,  2 Mar 2015 16:24:48 +0000 (UTC)
X-Virus-Checked: Checked by ClamAV on apache.org

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/531#discussion_r25611578
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/riak/RiakNodeSshDriver.java ---
    @@ -112,48 +106,65 @@ public void install() {
                     .execute();
         }
     
    -    private List<String> installLinux(String expandedInstallDir) {
    --- End diff --
    
    can we keep the old code -- maybe a new static `newTaskInstallToLinuxFromFiles(...)` method, possibly refactored to a `RiakInstallationUtils` class?
    
    ideally this would build up a task tree as part of the process -- using `Tasks` and `DynamicTasks` -- rather than create an enormous script.  i.e. trying the `packagecloud.io` install first, and if that fails it trying the old-style `fromFiles` link instead.  in the process @bostko you will probably encounter plenty of questions on tasks.  ask on these on IRC, and if necessary put together `tasks.md` page for the documentation.  (this is a bigger piece of work than is necessary, but it's something we've wanted for a while, plus it should be more interesting for you!)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---