brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix UsageResourceTest.testListApp...
Date Wed, 18 Mar 2015 13:42:02 GMT
GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/558

    Fix UsageResourceTest.testListApplicationUsages

    Context: this test is checking that the REST api for application-usage will report usage
in the specified time range. If we ask for usage between `Wed Mar 18 11:45:25 GMT 2015` and
`Wed Mar 18 11:45:25 GMT 2015` then we expect to be told about all apps that were in use during
that single second (and not to be told about the usage of those apps outside of that specific
second).
    
    - Was failing occasionally if the requested start/end date rounded down to a different
value than the postStart date.
    - I suspect 1 in 1000 chance, because depended if afterPostStart was in a different second
from postStart - it was adding 1ms to it. I suspect the original intent was to add 1 second.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn fix/UsageResourceTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/558.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #558
    
----
commit 1c9479b8804239c782ba05278d63c18771c93b98
Author: Aled Sage <aled.sage@gmail.com>
Date:   2015-03-18T13:38:59Z

    Fix UsageResourceTest.testListApplicationUsages
    
    - Was failing occasionally if the requested start/end date rounded down 
      to a different value than the postStart date.
    - I suspect 1 in 1000 chance, because depended if afterPostStart was in
      a different second from postStart - it was adding 1ms to it.
      I suspect the original intent was to add 1 second.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message