brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Riak - More statistics
Date Tue, 24 Mar 2015 00:56:15 GMT
Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/565#discussion_r26996027
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/riak/RiakNode.java ---
    @@ -29,12 +29,10 @@
     import brooklyn.entity.basic.SoftwareProcess;
     import brooklyn.entity.proxying.ImplementedBy;
     import brooklyn.event.AttributeSensor;
    -import brooklyn.event.basic.AttributeSensorAndConfigKey;
    -import brooklyn.event.basic.PortAttributeSensorAndConfigKey;
    -import brooklyn.event.basic.Sensors;
    -import brooklyn.event.basic.TemplatedStringAttributeSensorAndConfigKey;
    +import brooklyn.event.basic.*;
    --- End diff --
    
    No wildcard imports allowed. The standard for Brooklyn Java code is essentially the original
Sun **Java Code Conventions** (from 1997) which you can also find at Oracle [here](http://www.oracle.com/technetwork/java/codeconventions-150003.pdf).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message