brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix UsageResourceTest.testListApp...
Date Thu, 19 Mar 2015 13:40:02 GMT
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/558#issuecomment-83583488
  
    Thanks @neykov - I've incorporated your suggestions.
    
    Not sure I entirely follow. We're using `.compareTo(...) > 0` and `.compareTo(...)
< 0`, so they should cope fine with it being equal. It should always return us event details
about `startDate` to `endDate` (i.e. `afterPostStart` to `afterPostStart`, because that is
what we're now passing in as the time range).
    
    I've fine with the test taking an extra 1ms to be cautious though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message