brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: fixes for BrooklynNode and java a...
Date Wed, 18 Mar 2015 22:11:48 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/554#discussion_r26713113
  
    --- Diff: software/webapp/src/main/java/brooklyn/entity/webapp/JavaWebAppSshDriver.java
---
    @@ -89,11 +89,11 @@ protected String inferRootUrl() {
             if (isProtocolEnabled("https")) {
                 Integer port = getHttpsPort();
                 checkNotNull(port, "HTTPS_PORT sensors not set; is an acceptable port available?");
    -            return String.format("https://%s:%s/", getHostname(), port);
    +            return String.format("https://%s:%s/", getSubnetHostname(), port);
    --- End diff --
    
    Discovered a problem in EC2 with the naming strategy introduced in 89c126340dcf350a3d887782a5ea79a672fe2f17
-- have fixed it with an additional commit here, and detailed comments.
    
    Now confirmed that subnet hostname in AWS does the right thing.
    
    Merging with the add'l commit but @aledsage please look at b68363e8636a3e0c3cea28a2d39aa448e8d50650
in case you see a better way.  (Bear in mind jclouds wants a `Function<...Image...>`
and `Image` doesn't make the cloud provider available!)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message