brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: fixes for BrooklynNode and java a...
Date Wed, 18 Mar 2015 12:24:16 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/554#discussion_r26657989
  
    --- Diff: software/webapp/src/main/java/brooklyn/entity/webapp/JavaWebAppSshDriver.java
---
    @@ -89,11 +89,11 @@ protected String inferRootUrl() {
             if (isProtocolEnabled("https")) {
                 Integer port = getHttpsPort();
                 checkNotNull(port, "HTTPS_PORT sensors not set; is an acceptable port available?");
    -            return String.format("https://%s:%s/", getHostname(), port);
    +            return String.format("https://%s:%s/", getSubnetHostname(), port);
    --- End diff --
    
    Am I right that `getSubnetHostname()` will return the same as `getHostname()` if not running
in Clocker or a `SubnetTier`?
    
    What about for AWS - will the subnetHostname still be the public hostname, rather than
the private IP of the VM?
    
    Assuming so, this looks sensible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message