brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] incubator-brooklyn pull request: fixes for BrooklynNode and java a...
Date Wed, 18 Mar 2015 11:59:41 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: core/src/main/java/brooklyn/entity/rebind/dto/ ---
    @@ -68,10 +71,23 @@
         private MementosGenerators() {}
    +    /** @deprecated since 0.7.0 use {@link #newBasicMemento(BrooklynObject)} */
    --- End diff --
    Why rename from `newMemento(BrooklynObject)` to `newBasicMemento(BrooklynObject)`? Do
we have anything but "basic", or are we expecting that in the near future? Personally I prefer
`newMemento`, as "basic" implies there is some other kind of memento out there.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message