brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BROOKLYN-136: persist dynamic loc...
Date Wed, 18 Mar 2015 11:04:22 GMT
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/555#issuecomment-82901499
  
    Thanks @ahgittin @nakomis 
    
    For the failing `EmptySoftwareProcessYamlTest.testWithAppAndEntityLocations`, other tests
were previously failing non-deterministically for me because the `start()` effector was kicked
off asynchronously. For this test, I presume nothing was checking if the effector had actually
executed successfully. Now that the code blocks for `start()` to complete, we get this failure.
Have marked those as integration.
    
    Have incorporated review comments, and rebased. Will wait for jenkins, and then merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message