brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Mirroring entities should wait fo...
Date Tue, 17 Mar 2015 21:12:46 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/542#discussion_r26616906
  
    --- Diff: usage/rest-server/src/test/java/brooklyn/rest/BrooklynRestApiLauncher.java ---
    @@ -150,6 +152,11 @@ public BrooklynRestApiLauncher withoutJsgui() {
             this.deployJsgui = false;
             return this;
         }
    +    
    +    public BrooklynRestApiLauncher disableHighAvailability(boolean value) {
    --- End diff --
    
    I agree with you, I also prefer positive naming. In this case though it's more specific.
When the flag is `disableHighAvailability=true` the code calls
    ```
     mgmt.getHighAvailabilityManager().disabled();
    ```
    
    
    Having it named `enableHighAvailability=true` I would expect that it calls start on the
HA. By adding the flag I wanted to be able to say "don't disable HA".
    
    So wdyt, I don't mind changing it, but `enableHighAvailability` could lead to unmet expectations?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message