brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Mirroring entities should wait fo...
Date Tue, 17 Mar 2015 20:43:09 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/542#discussion_r26613978
  
    --- Diff: software/base/src/main/java/brooklyn/entity/brooklynnode/BrooklynNodeImpl.java
---
    @@ -153,17 +158,41 @@ protected void preStopConfirmCustom() {
         @Override
         protected void preStop() {
             super.preStop();
    +        if (MachineLifecycleEffectorTasks.canStop(getStopProcessModeParam(), this)) {
    +            shutdownGracefully();
    +        }
    +    }
    +
    +    private StopMode getStopProcessModeParam() {
    +        ConfigBag parameters = BrooklynTaskTags.getCurrentEffectorParameters();
    +        if (parameters != null) {
    +            return parameters.get(StopSoftwareParameters.STOP_PROCESS_MODE);
    --- End diff --
    
    This concerns the process only, stop machine mode not relevant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message