brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Mirroring entities should wait fo...
Date Wed, 11 Mar 2015 12:38:20 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/542#discussion_r26208066
  
    --- Diff: usage/rest-server/src/test/java/brooklyn/rest/BrooklynRestApiLauncher.java ---
    @@ -150,6 +152,11 @@ public BrooklynRestApiLauncher withoutJsgui() {
             this.deployJsgui = false;
             return this;
         }
    +    
    +    public BrooklynRestApiLauncher disableHighAvailability(boolean value) {
    --- End diff --
    
    Personal preference for fields/methods to be written in the positive rather than the negative.
    We could call the method/field `enableHighAvailability(boolean)`, defaulting to true.
    
    Other such examples include:
    
    * `JcloudsLocation.USE_JCLOUDS_SSH_INIT` rather than `DO_NOT_USE_JCLOUDS_SSH_INIT`.
    * `org.testng.annotations.Test.enabled` (rather than disabled)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message