brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Mirroring entities should wait fo...
Date Wed, 11 Mar 2015 12:34:12 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/542#discussion_r26207831
  
    --- Diff: software/base/src/main/java/brooklyn/entity/brooklynnode/BrooklynNodeImpl.java
---
    @@ -202,6 +229,15 @@ protected void postStop() {
             }
         }
     
    +    private boolean isStopMachine() {
    --- End diff --
    
    I was thrown by this method name when I looked at the impl.
    
    Should this method be called `isStoppingMachine()` or `isMachineStopped()` (I prefer the
former)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message