brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Undo #19, fixed upstream
Date Tue, 10 Mar 2015 12:36:24 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/502#discussion_r26117218
  
    --- Diff: locations/jclouds/src/test/java/brooklyn/entity/rebind/persister/jclouds/BlobStoreExpiryTest.java
---
    @@ -91,7 +91,7 @@
         private String provider;
         private String endpoint;
     
    -    public synchronized BlobStoreContext getBlobStoreContext(boolean applyFix) {
    +    public synchronized BlobStoreContext getBlobStoreContext() {
    --- End diff --
    
    This test assumes the endpoint will be Swift, but nothing in the class explicitly says
that the test endpoint must be swift (there is just an "e.g." in some example brooklyn.properties).
Would be worth being explicit about that requirement.
    
    Note this was a problem with the code before @neykov improved it, so I'm not too bothered
if it's included in this PR or another.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message