brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Encapsulate all CAMP calls in a s...
Date Fri, 06 Mar 2015 17:17:30 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/545#discussion_r25960264
  
    --- Diff: usage/camp/src/main/java/io/brooklyn/camp/brooklyn/YamlLauncherAbstract.java
---
    @@ -79,8 +80,8 @@ public Application launchAppYaml(String url) {
     
         public Application launchAppYaml(String url, boolean waitForTasksToComplete) {
             try {
    -            Reader input = Streams.reader(new ResourceUtils(this).getResourceFromUrl(url));
    -            Application app = launchAppYaml(input, waitForTasksToComplete);
    --- End diff --
    
    This is the wrong method to update, replace the one that was called here. For a global
check if the patch was successful check for references like `registerDeploymentPlan`, `instantiate`,
they should we restricted to the `EntityManagementUtils` class only (outside of camp projects).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message