brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] incubator-brooklyn pull request: Adds addAssociationListener and r...
Date Tue, 03 Mar 2015 15:17:25 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: core/src/main/java/brooklyn/location/access/ ---
    @@ -208,6 +223,7 @@ public boolean forgetPortMapping(String publicIpId, int publicPort)
             PortMapping old;
             synchronized (mutex) {
                 old = mappings.remove(makeKey(publicIpId, publicPort));
    +            emitAssociationDeletedEvent(associationMetadataFromPortMapping(old));
    --- End diff --
    Guard this with `if (old != null)` - i.e. was something really removed?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message