brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nakomis <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Adds addAssociationListener and r...
Date Tue, 03 Mar 2015 09:52:17 GMT
Github user nakomis commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/538#discussion_r25674284
  
    --- Diff: core/src/main/java/brooklyn/location/access/PortForwardManagerImpl.java ---
    @@ -38,12 +25,25 @@
     import brooklyn.location.basic.AbstractLocation;
     import brooklyn.mementos.LocationMemento;
     import brooklyn.util.collections.MutableMap;
    -
     import com.google.common.base.Objects.ToStringHelper;
    +import com.google.common.base.Predicate;
     import com.google.common.collect.ImmutableList;
     import com.google.common.collect.ImmutableMap;
     import com.google.common.collect.Lists;
     import com.google.common.net.HostAndPort;
    +import org.slf4j.Logger;
    --- End diff --
    
    I'm finding inconsistencies in how Eclipse organises the imports. Configuring IntelliJ
to have the same imports list as Eclipse unfortunately doesn't work. As @neykov put it: "One
of the IDEs (don't remember which) was interleaving packages not specified in the list, while
the other was putting them at the start and then listing the remaining packages."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message