brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Adds addAssociationListener and r...
Date Mon, 02 Mar 2015 21:08:42 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/538#discussion_r25638589
  
    --- Diff: core/src/main/java/brooklyn/location/access/PortForwardManager.java ---
    @@ -46,6 +47,42 @@
     @Beta
     public interface PortForwardManager extends Location {
     
    +    @Beta
    +    class AssociationMetadata {
    --- End diff --
    
    Worth adding `toString()` to this - you rely on a nice toString in a debug message of
https://github.com/brooklyncentral/advanced-networking/pull/39
    
    e.g.:
    
        public String toString() {
            return Objects.toStringHelper()
                    .add("publicIpId", publicIpId)
                    .add("publicEndpoint", publicEndpoint)
                    .add("location", location)
                    .add("privatePort", privatePort)
                    .build();
        }



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message