brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] incubator-brooklyn pull request: Adds addAssociationListener and r...
Date Mon, 02 Mar 2015 20:53:01 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: core/src/main/java/brooklyn/location/access/ ---
    @@ -78,7 +78,9 @@
         private static final Logger log = LoggerFactory.getLogger(PortForwardManagerImpl.class);
         protected final Map<String,PortMapping> mappings = new LinkedHashMap<String,PortMapping>();
    +    private Map<AssociationListener, Predicate<? super AssociationMetadata>>
associationListeners = new ConcurrentHashMap<AssociationListener, Predicate<? super
    --- End diff --
    Declare the field `final`. It makes reasoning about the code simpler for folk reading
or modifying it later.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message