brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Adds addAssociationListener and r...
Date Mon, 02 Mar 2015 20:42:23 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/538#discussion_r25636341
  
    --- Diff: core/src/main/java/brooklyn/location/access/PortForwardManager.java ---
    @@ -46,6 +47,42 @@
     @Beta
     public interface PortForwardManager extends Location {
     
    +    @Beta
    +    class AssociationMetadata {
    +        private final String publicIpId;
    +        private final HostAndPort publicEndpoint;
    +        private final Location location;
    +        private final int privatePort;
    +
    +        public AssociationMetadata(String publicIpId, HostAndPort publicEndpoint, Location
location, int privatePort) {
    --- End diff --
    
    Worth a javadoc to say: `Users are discouraged from calling this constructor; the signature
may change in future releases. Instead, instances will be created automatically by Brooklyn
to be passed to the {@link AssociationListener#onEvent(AssociationMetadata)} method.`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message