brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Basho Riak - Linux Install
Date Mon, 02 Mar 2015 16:24:48 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/531#discussion_r25611578
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/riak/RiakNodeSshDriver.java
---
    @@ -112,48 +106,65 @@ public void install() {
                     .execute();
         }
     
    -    private List<String> installLinux(String expandedInstallDir) {
    --- End diff --
    
    can we keep the old code -- maybe a new static `newTaskInstallToLinuxFromFiles(...)` method,
possibly refactored to a `RiakInstallationUtils` class?
    
    ideally this would build up a task tree as part of the process -- using `Tasks` and `DynamicTasks`
-- rather than create an enormous script.  i.e. trying the `packagecloud.io` install first,
and if that fails it trying the old-style `fromFiles` link instead.  in the process @bostko
you will probably encounter plenty of questions on tasks.  ask on these on IRC, and if necessary
put together `tasks.md` page for the documentation.  (this is a bigger piece of work than
is necessary, but it's something we've wanted for a while, plus it should be more interesting
for you!)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message