Return-Path: X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7660D100CC for ; Mon, 9 Feb 2015 17:46:38 +0000 (UTC) Received: (qmail 26861 invoked by uid 500); 9 Feb 2015 17:46:38 -0000 Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org Received: (qmail 26826 invoked by uid 500); 9 Feb 2015 17:46:38 -0000 Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.incubator.apache.org Delivered-To: mailing list dev@brooklyn.incubator.apache.org Received: (qmail 26815 invoked by uid 99); 9 Feb 2015 17:46:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Feb 2015 17:46:38 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 09 Feb 2015 17:46:36 +0000 Received: (qmail 23954 invoked by uid 99); 9 Feb 2015 17:46:16 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Feb 2015 17:46:16 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8B391DF986; Mon, 9 Feb 2015 17:46:16 +0000 (UTC) From: ahgittin To: dev@brooklyn.incubator.apache.org Reply-To: dev@brooklyn.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-brooklyn pull request: fix time-sensitive sensor derivat... Content-Type: text/plain Message-Id: <20150209174616.8B391DF986@git1-us-west.apache.org> Date: Mon, 9 Feb 2015 17:46:16 +0000 (UTC) X-Virus-Checked: Checked by ClamAV on apache.org Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/501#issuecomment-73554351 thanks @aledsage; i've implemented your suggestions, apart from `Propagator` where I've now added a TODO. you are right in your thinking that we want this for `Propagator`; I simply hadn't noticed it. it was `Transformer` that was causing the errors i was encountering. however fixing it for propagator seems a little less clear-cut, and i've not tested it, so all i have done is the todo. I think to fix, we need to make a timestamp a first-class property of sensors. okay to merge as changed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---