brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Misc tidies
Date Sat, 28 Feb 2015 23:18:03 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/535#discussion_r25562254
  
    --- Diff: core/src/main/java/brooklyn/entity/basic/AbstractEntity.java ---
    @@ -962,7 +962,9 @@ public void removeAttribute(AttributeSensor<?> attribute) {
         // -------- CONFIGURATION --------------
     
         @Override
    -    public ConfigurationSupportInternal config() {
    +    // the concrete type rather than an interface is returned because Groovy subclasses
    +    // complain (incorrectly) if we return ConfigurationSupportInternal 
    +    public BasicConfigurationSupport config() {
    --- End diff --
    
    On balance I'm fine with this, but really would prefer if the impl did not leak as that
ties us down for future refactoring. Perhaps we should add an `@Beta` to this method, and
add javadoc explaining why (saying that it may change to return a `ConfigurationSupportInternal`
in a future release, that being the preferred way to use it).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message