brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Refactor config methods
Date Wed, 18 Feb 2015 11:31:30 GMT
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/320#issuecomment-74850106
  
    I've incorporated comments from @sjcorbett and then rebased against master.
    
    Only comment not addressed is from @grkvlt about `<T> T set(ConfigKey<T> key,
T val)`: "Should we support setting an Object value instead and doing type coercion if possible?".
Let's look at that in a separate PR if we choose to do it. I'm not sure yet either way.
    
    Will merge now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message