brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: set IS_IN_CLUSTER on couchbase pr...
Date Wed, 18 Feb 2015 10:54:03 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/488#discussion_r24893169
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/couchbase/CouchbaseClusterImpl.java
---
    @@ -229,8 +229,13 @@ protected void doStart() {
                     }
                     
                     ((CouchbaseNode)getPrimaryNode()).rebalance();
    -            } else if (getQuorumSize()>1) {
    -                log.warn(this+" is not quorate; will likely fail later, but proceeding
for now");
    +            } else {
    +                if (getQuorumSize()>1) {
    +                    log.warn(this+" is not quorate; will likely fail later, but proceeding
for now");
    +                }
    +                if (!serversToAdd.isEmpty()) {
    +                    ((EntityInternal) Iterables.getOnlyElement(serversToAdd)).setAttribute(CouchbaseNode.IS_IN_CLUSTER,
true);
    --- End diff --
    
    How do you know that `serversToAdd` will only have one element? If quorum size was 3,
then presumably you could get into this code path with serversToAdd having size 2?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message