brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Adds getConfig method to server R...
Date Mon, 09 Feb 2015 16:43:59 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/509#discussion_r24342511
  
    --- Diff: usage/rest-server/src/main/java/brooklyn/rest/resources/ServerResource.java
---
    @@ -238,6 +240,12 @@ public String getStatus() {
             return getHighAvailabilityNodeState().toString();
         }
     
    +    @Override
    +    public String getConfig(String configKey) {
    +        ConfigKey<String> config = ConfigKeys.newStringConfigKey(configKey);
    --- End diff --
    
    Worth including an entitlements check, because the return values could contain passwords
retrieved from `brooklyn.properties`. For example, something like:
    
        if (!Entitlements.isEntitled(mgmt().getEntitlementManager(), Entitlements.SEE_ALL_SERVER_INFO,
null)) {
            throw WebResourceUtils.unauthorized("User '%s' is not authorized for this operation",
Entitlements.getEntitlementContext().user());
        }



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message