brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: CLI better default, port/https co...
Date Mon, 09 Feb 2015 14:45:55 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/478#discussion_r24332021
  
    --- Diff: usage/launcher/src/main/java/brooklyn/launcher/BrooklynWebServer.java ---
    @@ -338,7 +346,10 @@ public synchronized void start() throws Exception {
             if (actualPort == -1){
                 PortRange portRange = requestedPort;
                 if (portRange==null) {
    -                portRange = getHttpsEnabled()? httpsPort : httpPort;
    +                portRange = managementContext.getConfig().getConfig(BrooklynWebConfig.WEB_CONSOLE_PORT);
    +            }
    +            if (portRange==null) {
    +                portRange = getHttpsEnabled() ? httpsPort : httpPort;
    --- End diff --
    
    Backwards compatibility warning: if `brooklyn.webconsole.security.https.required=true`
was used previously without explicit port, the server would still start on 8081.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message