brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Active partial rebind allowing ca...
Date Mon, 09 Feb 2015 13:06:17 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/506#discussion_r24326262
  
    --- Diff: core/src/main/java/brooklyn/entity/rebind/RebindManagerImpl.java ---
    @@ -361,6 +364,38 @@ public void stop() {
             if (persistenceStoreAccess != null) persistenceStoreAccess.stop(true);
         }
         
    +        
    +    public void rebindPartialActive(CompoundTransformer transformer, Iterator<BrooklynObject>
objectsToRebind) {
    +        final ClassLoader classLoader = 
    +            managementContext.getCatalog().getRootClassLoader();
    +        final RebindExceptionHandler exceptionHandler = 
    +            RebindExceptionHandlerImpl.builder()
    +                .danglingRefFailureMode(danglingRefFailureMode)
    --- End diff --
    
    have added a TODO
    
    the update-proxy-then-unmanage-old is mostly atomic so most failures should be pretty
safe, but i'm sure there will be edge conditions
    
    when we better understand the failure dimensions (and have visualization) then we can
tidy this up


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message