brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: fix JcloudsMachineNamer
Date Sun, 01 Feb 2015 00:04:55 GMT
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/481#issuecomment-72343778
  
    @aledsage i think andrea's description "fix JcloudsMachineNamer -- remove maxLenght for
SoftLayer" is more accurate than your suggestion, spelling aside :) .  did you not see his
expanded message or were you suggesting something else?
    
    i confess i'm never sure how much to put in the one-line summary.  following @richardcloudsoft
's advice i now tend to keep the first line short-ish, so that it renders neatly (though in
this case all of andrea's text could have been on one line).  however i do wonder how many
people actually see the detail in the rest of the message, particularly when doing code reviews.
    
    [ironic to be discussing this in a PR about max-length!]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message