Return-Path: X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D10601743D for ; Tue, 27 Jan 2015 13:33:55 +0000 (UTC) Received: (qmail 96890 invoked by uid 500); 27 Jan 2015 13:33:56 -0000 Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org Received: (qmail 96844 invoked by uid 500); 27 Jan 2015 13:33:56 -0000 Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.incubator.apache.org Delivered-To: mailing list dev@brooklyn.incubator.apache.org Received: (qmail 96832 invoked by uid 99); 27 Jan 2015 13:33:56 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jan 2015 13:33:56 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 27 Jan 2015 13:33:55 +0000 Received: (qmail 96487 invoked by uid 99); 27 Jan 2015 13:33:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jan 2015 13:33:35 +0000 Date: Tue, 27 Jan 2015 13:33:35 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@brooklyn.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BROOKLYN-128) ArchiveUtils ignores destFile, prefers optionalDestFile during deploy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/BROOKLYN-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293505#comment-14293505 ] ASF GitHub Bot commented on BROOKLYN-128: ----------------------------------------- Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/472#issuecomment-71647677 @michaeldye have you signed a CLA (contributor license agreement) with Apache? There are details of how to do this at https://brooklyn.incubator.apache.org/developers/how-to-contribute.html > ArchiveUtils ignores destFile, prefers optionalDestFile during deploy > --------------------------------------------------------------------- > > Key: BROOKLYN-128 > URL: https://issues.apache.org/jira/browse/BROOKLYN-128 > Project: Brooklyn > Issue Type: Bug > Affects Versions: 0.7.0-M2 > Reporter: michael dye > Fix For: 0.7.0-M2 > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > When deploying apps using a Chef recipe, ArchiveUtils.deploy(ResourceUtils, Map, String, SshMachineLocation, String, boolean, String, String) issues an install command with optionalDestFile (which may be null) rather than with destFile which is properly guarded and makes use of optionalDestFile if provided. Stacktrace from NPE encountered: > {noformat} > Failed after 4.62s: Error invoking start at ChefEntityImpl{id=QTkh3uaF}: java.lang.NullPointerException > brooklyn.util.exceptions.PropagatedRuntimeException: Error invoking start at ChefEntityImpl{id=QTkh3uaF}: java.lang.NullPointerException > at brooklyn.util.exceptions.Exceptions.propagate(Exceptions.java:91) > at brooklyn.util.task.ParallelTask.runJobs(ParallelTask.java:80) > at brooklyn.util.task.CompoundTask$1.call(CompoundTask.java:82) > at brooklyn.util.task.CompoundTask$1.call(CompoundTask.java:1) > at brooklyn.util.task.BasicExecutionManager$SubmissionCallable.call(BasicExecutionManager.java:469) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > ... > at brooklyn.util.file.ArchiveUtils.installCommands(ArchiveUtils.java:111) > at brooklyn.util.file.ArchiveUtils.deploy(ArchiveUtils.java:275) > at brooklyn.util.file.ArchiveTasks$1$1.run(ArchiveTasks.java:47) > at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > at brooklyn.util.task.DynamicSequentialTask$DstJob.call(DynamicSequentialTask.java:337) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)