Return-Path: X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CBE8D17F19 for ; Fri, 30 Jan 2015 23:59:41 +0000 (UTC) Received: (qmail 45890 invoked by uid 500); 30 Jan 2015 23:59:42 -0000 Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org Received: (qmail 45854 invoked by uid 500); 30 Jan 2015 23:59:42 -0000 Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.incubator.apache.org Delivered-To: mailing list dev@brooklyn.incubator.apache.org Received: (qmail 59290 invoked by uid 99); 30 Jan 2015 13:58:01 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Jan 2015 13:58:01 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 30 Jan 2015 13:57:59 +0000 Received: (qmail 58999 invoked by uid 99); 30 Jan 2015 13:57:39 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Jan 2015 13:57:39 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id DD20EE0411; Fri, 30 Jan 2015 13:57:38 +0000 (UTC) From: ahgittin To: dev@brooklyn.incubator.apache.org Reply-To: dev@brooklyn.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-brooklyn pull request: nginx support for upstream https,... Content-Type: text/plain Message-Id: <20150130135738.DD20EE0411@git1-us-west.apache.org> Date: Fri, 30 Jan 2015 13:57:38 +0000 (UTC) X-Virus-Checked: Checked by ClamAV on apache.org Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/479#issuecomment-72204134 looks good. i will add comments to the effect that the `SERVER_CONF_TEMPLATE_URL` key is only used if `SERVER_CONF_GENERATOR` is explicitly specified to point to `NginxTemplateConfigGenerator`. it would probably be cleaner if the DefaultConfigGenerator looked at `SERVER_CONF_TEMPLATE_URL` key and switched to use it if there is an explicit value set, just in case someone tries to use the key only. but not needed for this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---