Return-Path: 
 <dev-return-5480-apmail-brooklyn-dev-archive=brooklyn.apache.org@brooklyn.incubator.apache.org>
X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id C6F62179DA
	for <apmail-brooklyn-dev-archive@minotaur.apache.org>;
 Wed, 28 Jan 2015 09:11:15 +0000 (UTC)
Received: (qmail 82601 invoked by uid 500); 28 Jan 2015 09:11:16 -0000
Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org
Received: (qmail 82573 invoked by uid 500); 28 Jan 2015 09:11:16 -0000
Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.incubator.apache.org>
List-Post: <mailto:dev@brooklyn.incubator.apache.org>
List-Id: <dev.brooklyn.incubator.apache.org>
Reply-To: dev@brooklyn.incubator.apache.org
Delivered-To: mailing list dev@brooklyn.incubator.apache.org
Received: (qmail 82532 invoked by uid 99); 28 Jan 2015 09:11:15 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jan 2015 09:11:15 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Wed, 28 Jan 2015 09:11:13 +0000
Received: (qmail 77125 invoked by uid 99); 28 Jan 2015 09:10:53 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jan 2015 09:10:53 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 80F12E03EE; Wed, 28 Jan 2015 09:10:52 +0000 (UTC)
From: mattunderscorechampion <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-480-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-480-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Release ports acquired when
 check...
Content-Type: text/plain
Message-Id: <20150128091052.80F12E03EE@git1-us-west.apache.org>
Date: Wed, 28 Jan 2015 09:10:52 +0000 (UTC)
X-Virus-Checked: Checked by ClamAV on apache.org

Github user mattunderscorechampion commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/480#issuecomment-71802104
  
    Having reviewed the build failure.
    
    A NullPointerException is thrown when parsing a string to URI.
    
    [URI.create(..)](http://docs.oracle.com/javase/7/docs/api/java/net/URI.html#create(java.lang.String)) throws a NullPointerException if the value passed to it is null.
    
    AbstractControllerImpl.computePortsAndUrls(..) is calling URI.create(..) with the value returned by AbstractControllerImpl.inferUrl(..).
    
    AbstractControllerImpl.inferUrl(..) will return null if the domain is null. Either from the AbstractControllerImpl.getDomain(..), HostAndPort.getHostText(..) or LoadBalancer.HOSTNAME attribute.
    
    It is not clear to me why changing the port assignment would affect the domain name.
    
    Stacktrace fragment:
    Caused by: java.lang.NullPointerException: null
    	at java.net.URI$Parser.parse(URI.java:3004)
    	at java.net.URI.<init>(URI.java:577)
    	at java.net.URI.create(URI.java:839)
    	at brooklyn.entity.proxy.AbstractControllerImpl.computePortsAndUrls(AbstractControllerImpl.java:314)
    	at brooklyn.entity.proxy.AbstractControllerImpl.preStart(AbstractControllerImpl.java:299)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---