Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-465-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-465-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Jclouds tidy
Content-Type: text/plain
Message-Id: <20150126104228.B8E7CE03F2@git1-us-west.apache.org>
Date: Mon, 26 Jan 2015 10:42:28 +0000 (UTC)

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/465#discussion_r23522215
  
    --- Diff: core/src/test/java/brooklyn/util/crypto/SecureKeysAndSignerTest.java ---
    @@ -93,6 +95,40 @@ public void testReadRsaKey() throws Exception {
             checkNonTrivial(key);
         }
     
    +    @Test(expectedExceptions=IllegalStateException.class)
    +    public void testReadRsaPublicKeyAsPemFails() throws Exception {
    +        // should fail; see next test
    +        SecureKeys.readPem(ResourceUtils.create(this).getResourceFromUrl("classpath://brooklyn/util/crypto/sample_rsa.pem.pub"), null);
    +    }
    +    
    +    @Test
    +    public void testReadRsaPublicKeyAsAuthKeysWorks() throws Exception {
    +        PublicKey key = AuthorizedKeysParser.decodePublicKey(
    +            ResourceUtils.create(this).getResourceAsString("classpath://brooklyn/util/crypto/sample_rsa.pem.pub"));
    +        KeyPair fromPem = SecureKeys.readPem(ResourceUtils.create(this).getResourceFromUrl("classpath://brooklyn/util/crypto/sample_rsa.pem"), null);        
    --- End diff --
    
    maybe it is big enough rat can tell it isn't human readable?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---