brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-128) ArchiveUtils ignores destFile, prefers optionalDestFile during deploy
Date Tue, 27 Jan 2015 16:26:35 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293760#comment-14293760
] 

ASF GitHub Bot commented on BROOKLYN-128:
-----------------------------------------

Github user michaeldye commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/472#issuecomment-71677344
  
    @aledsage Thank you very much for the feedback, I agree with your coverage desire and
will ensure my future PRs extend coverage.


> ArchiveUtils ignores destFile, prefers optionalDestFile during deploy
> ---------------------------------------------------------------------
>
>                 Key: BROOKLYN-128
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-128
>             Project: Brooklyn
>          Issue Type: Bug
>    Affects Versions: 0.7.0-M2
>            Reporter: michael dye
>             Fix For: 0.7.0-SNAPSHOT
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> When deploying apps using a Chef recipe, ArchiveUtils.deploy(ResourceUtils, Map<String,
?>, String, SshMachineLocation, String, boolean, String, String) issues an install command
with optionalDestFile (which may be null) rather than with destFile which is properly guarded
and makes use of optionalDestFile if provided. Stacktrace from NPE encountered:
> {noformat}
> Failed after 4.62s: Error invoking start at ChefEntityImpl{id=QTkh3uaF}: java.lang.NullPointerException
> brooklyn.util.exceptions.PropagatedRuntimeException: Error invoking start at ChefEntityImpl{id=QTkh3uaF}:
java.lang.NullPointerException
> 	at brooklyn.util.exceptions.Exceptions.propagate(Exceptions.java:91)
> 	at brooklyn.util.task.ParallelTask.runJobs(ParallelTask.java:80)
> 	at brooklyn.util.task.CompoundTask$1.call(CompoundTask.java:82)
> 	at brooklyn.util.task.CompoundTask$1.call(CompoundTask.java:1)
> 	at brooklyn.util.task.BasicExecutionManager$SubmissionCallable.call(BasicExecutionManager.java:469)
> 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> 	at java.lang.Thread.run(Thread.java:745)
> ...
> 	at brooklyn.util.file.ArchiveUtils.installCommands(ArchiveUtils.java:111)
> 	at brooklyn.util.file.ArchiveUtils.deploy(ArchiveUtils.java:275)
> 	at brooklyn.util.file.ArchiveTasks$1$1.run(ArchiveTasks.java:47)
> 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> 	at brooklyn.util.task.DynamicSequentialTask$DstJob.call(DynamicSequentialTask.java:337)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message