brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andreaturli <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: fix maven javac purity on JDK7
Date Fri, 30 Jan 2015 10:10:09 GMT
Github user andreaturli commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/493#discussion_r23833260
  
    --- Diff: camp/camp-base/src/main/java/io/brooklyn/camp/spi/AbstractResource.java ---
    @@ -94,66 +93,66 @@ public RepresentationSkew getRepresentationSkew() {
         public Map<String, Object> getCustomAttributes() {
             return ImmutableMap.copyOf(customAttributes);
         }
    -    
    +
         // setters
     
    -    private void setId(String id) {
    +    void setId(String id) {
             this.id = id;
         }
    -    private void setName(String name) {
    +    void setName(String name) {
             this.name = name;
         }
    -    private void setDescription(String description) {
    +    void setDescription(String description) {
             this.description = description;
         }
    -    private void setSourceCode(String sourceCode) {
    +    void setSourceCode(String sourceCode) {
             this.sourceCode = sourceCode;
         }
    -    private void setCreated(Date created) {
    +    void setCreated(Date created) {
             // precision beyond seconds breaks equals check
             this.created = Time.dropMilliseconds(created);
         }
    -    private void setTags(List<String> tags) {
    +    void setTags(List<String> tags) {
             this.tags = ImmutableList.copyOf(tags);
         }
    -    private void setType(String type) {
    +    void setType(String type) {
             this.type = type;
         }
    -    private void setRepresentationSkew(RepresentationSkew representationSkew) {
    +    void setRepresentationSkew(RepresentationSkew representationSkew) {
             this.representationSkew = representationSkew;
         }
    -    public void setCustomAttribute(String key, Object value) {
    +    void setCustomAttribute(String key, Object value) {
    --- End diff --
    
    not sure it is needed to have `public` here, but happy to revert.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message